View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0002398GeoSetterUser Interfacepublic2022-12-20 20:572023-02-01 20:25
Reporterxyzzy Assigned ToFriedemann  
PrioritynormalSeverityfeatureReproducibilityhave not tried
Status resolvedResolutionfixed 
Product Version 
Target VersionFixed in Version4.0.38 beta 
Summary0002398: Version 4.0.4 - Images of favorites (selected/unselected) have been inverted
DescriptionReplace rows in "map.js"
    _getFavoriteIcon: function (selected) {
        if (selected) {
            if (!this.favoriteIconSelected) {
                this.favoriteIconSelected = L.icon({
                    iconUrl: 'img/marker_favorite.png',
                    iconAnchor: [16, 16],
                    popupAnchor: [0, 0]
                });
            }
            return this.favoriteIconSelected;
        } else {
            if (!this.favoriteIconUnselected) {
                this.favoriteIconUnselected = L.icon({
                    iconUrl: 'img/marker_favorite_selected.png',
                    iconAnchor: [16, 16],
                    popupAnchor: [0, 0]
                });
            }
            return this.favoriteIconUnselected;
        }
    },

by
    _getFavoriteIcon: function (selected) {
        if (selected) {
            if (!this.favoriteIconSelected) {
                this.favoriteIconSelected = L.icon({
                    iconUrl: 'img/marker_favorite_selected.png',
                    iconAnchor: [16, 16],
                    popupAnchor: [0, 0]
                });
            }
            return this.favoriteIconSelected;
        } else {
            if (!this.favoriteIconUnselected) {
                this.favoriteIconUnselected = L.icon({
                    iconUrl: 'img/marker_favorite.png',
                    iconAnchor: [16, 16],
                    popupAnchor: [0, 0]
                });
            }
            return this.favoriteIconUnselected;
        }
    },
TagsNo tags attached.

Activities

xyzzy

2023-01-16 15:43

reporter   ~0004397

@heiko : Has been corrected. You can close this request

xyzzy

2023-01-28 00:02

reporter   ~0004469

@heiko: You can close this issue. Works in 4.0.33. (Less work for Friedemann)

xyzzy

2023-02-01 15:00

reporter   ~0004502

@Friedemann: you can close this issue: Work since 4.0.33

Issue History

Date Modified Username Field Change
2022-12-20 20:57 xyzzy New Issue
2022-12-21 09:31 Friedemann Status new => assigned
2022-12-21 09:31 Friedemann Assigned To => Friedemann
2023-01-16 15:43 xyzzy Note Added: 0004397
2023-01-28 00:02 xyzzy Note Added: 0004469
2023-02-01 15:00 xyzzy Note Added: 0004502
2023-02-01 20:25 heiko Status assigned => resolved
2023-02-01 20:25 heiko Resolution open => fixed
2023-02-01 20:25 heiko Fixed in Version => 4.0.38 beta